Skip to content

Conversation

@epenet
Copy link
Contributor

@epenet epenet commented Dec 9, 2025

Proposed change

As spotted in #158463
Extracted from #158474, and targetting rc to prevent merge conflicts from #157958 / #157968 / #158028

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added bugfix cla-signed integration: tuya merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines. labels Dec 9, 2025
@home-assistant
Copy link

home-assistant bot commented Dec 9, 2025

Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet epenet added this to the 2025.12.3 milestone Dec 9, 2025
@epenet epenet marked this pull request as ready for review December 9, 2025 16:31
Copilot AI review requested due to automatic review settings December 9, 2025 16:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the BitmapTypeInformation.from_json method that was incorrectly parsing JSON data. The fix changes from using dictionary unpacking with an overly specific cast to explicitly extracting the label field, making it consistent with the IntegerTypeData pattern.

  • Fixed incorrect dictionary unpacking pattern in BitmapTypeInformation.from_json
  • Added proper type cast for json_loads_object return value
  • Changed to explicit field extraction for better clarity and type safety

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck merged commit 27fa92b into rc Dec 10, 2025
41 of 42 checks passed
@frenck frenck deleted the epenet-20251209-1729 branch December 10, 2025 16:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cherry-picked cla-signed integration: tuya merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants