Skip to content

Conversation

@allenporter
Copy link
Contributor

@allenporter allenporter commented Dec 10, 2025

Proposed change

Bump python-roborock to 3.12.2
Changes: Python-roborock/python-roborock@v3.10.10...v3.12.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the python-roborock library dependency from version 3.10.10 to 3.12.1 to fix issue #158306. The version update is applied consistently across all required dependency files and the integration manifest.

Key changes:

  • Updated python-roborock dependency version from 3.10.10 to 3.12.1 across all dependency files

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
requirements_test_all.txt Updated python-roborock test dependency version to 3.12.1
requirements_all.txt Updated python-roborock production dependency version to 3.12.1
homeassistant/components/roborock/manifest.json Updated python-roborock requirement in integration manifest to 3.12.1

The dependency bump is straightforward and consistent across all three required files. No integration code changes are needed as this appears to be a bug fix release in the library. The version update has been applied correctly to the manifest, main requirements, and test requirements files.

@allenporter allenporter marked this pull request as draft December 10, 2025 15:09
@allenporter allenporter changed the title Bump python-roborock to 3.12.1 Bump python-roborock to 3.12.2 Dec 10, 2025
@allenporter allenporter marked this pull request as ready for review December 10, 2025 15:14
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @allenporter 👍

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck merged commit d65baac into home-assistant:dev Dec 10, 2025
67 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roborock can't Add Integrarion due to "parameter error - response code: 1002" Roborock "Failed to decode message" for L01 devices

2 participants