Suppress roborock failures under some unavailability threshold

[allenporter]

We aggressively refresh roborock devices local channel (every 30 seconds) and there is a known issue where devices go unavailable around 3am every day for a period of ~1 minute which causes log spam during a non-critical background refresh. We instead will suppress refresh failures until a minimum unavailability threshold has passed.

Proposed change

Suppress roborock failures under some unavailability threshold to handle the 3am unavailability issue.

Other members: Very happy to have review/approval, but I would request you let me merge this myself. Also, I would like to target this for 2025.1.x, and not a patch release since it is a long standing issue.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Roborock device goes unavailable every night #98013
• This PR is related to issue:
• Link to documentation pull request:
• Link to developer documentation pull request:
• Link to frontend pull request:

Checklist

• I understand the code I am submitting and can explain how it works.
• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.
• Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[Copilot]

Pull request overview

This PR addresses a known issue where Roborock devices temporarily go offline around 3am for approximately 1 minute, causing log spam during routine background refreshes. The solution implements an unavailability threshold that suppresses reporting update failures until 2 minutes of consecutive failures have occurred.

Key changes:

• Added time-based failure suppression logic to avoid marking devices as unavailable during brief outages
• Improved exception handling by changing HomeAssistantError to UpdateFailed in update_map() for consistency
• Added comprehensive test coverage for the unavailability threshold behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
homeassistant/components/roborock/coordinator.py	Implements unavailability threshold by tracking last successful update time and suppressing failures under 2 minutes; changes update_map() to raise UpdateFailed instead of HomeAssistantError for consistency
tests/components/roborock/test_init.py	Adds comprehensive test that verifies entities remain available during short failure periods (90 seconds), become unavailable after exceeding threshold (4.5 minutes total), and recover when updates resume

[joostlek]

Should this be picked for a patch?

[allenporter]

Should this be picked for a patch?

See the PR description, i was expecting to wait on this, but maybe i'm being too conservative.

[joostlek]

OH, sorry, I missed the description 😓 Sorry