Skip to content

Conversation

@ndrwrbgs
Copy link
Contributor

@ndrwrbgs ndrwrbgs commented Dec 11, 2025

Proposed change

Config Flow from the UI

Updating the text in the image to match the button

Type of change

⚠️❓I'm not sure any of the below fit this change, I looked for a "docs" option.
It looks like @emontnemery used "Code quality improvements" in the similar #157643, but since the change is visible to end users that "felt" like it could confuse any future release automation. Does this suggest a need for adding another option?

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • [❓Not applicable] Tests have been added to verify that the new code works.
  • [❓Not applicable] Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @emontnemery, @jbouwh, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thanks @ndrwrbgs 👍

P.s. mark the PR Ready for review to allow it to be merged

@ndrwrbgs
Copy link
Contributor Author

@jbouwh sure thing, wasn’t able to run the tests locally or review other PRs yet so it was in draft, but I imagine the GitHub actions also run tests?

@ndrwrbgs ndrwrbgs marked this pull request as ready for review December 11, 2025 21:09
@jbouwh
Copy link
Contributor

jbouwh commented Dec 11, 2025

@jbouwh sure thing, wasn’t able to run the tests locally or review other PRs yet so it was in draft, but I imagine the GitHub actions also run tests?

We don't always have tests for translations.

@jbouwh jbouwh merged commit ff62b46 into home-assistant:dev Dec 11, 2025
66 checks passed
@jbouwh jbouwh added this to the 2025.12.3 milestone Dec 11, 2025
18339167199 pushed a commit to 18339167199/homeassistant-core that referenced this pull request Dec 12, 2025
@frenck frenck mentioned this pull request Dec 12, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants