-
-
Notifications
You must be signed in to change notification settings - Fork 36.3k
Update advanced_options display text for MQTT #158728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey there @emontnemery, @jbouwh, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
jbouwh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thanks @ndrwrbgs 👍
P.s. mark the PR Ready for review to allow it to be merged
|
@jbouwh sure thing, wasn’t able to run the tests locally or review other PRs yet so it was in draft, but I imagine the GitHub actions also run tests? |
We don't always have tests for translations. |
Proposed change
Updating the text in the image to match the button
Type of change
It looks like @emontnemery used "Code quality improvements" in the similar #157643, but since the change is visible to end users that "felt" like it could confuse any future release automation. Does this suggest a need for adding another option?
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: