-
-
Notifications
You must be signed in to change notification settings - Fork 36.3k
Bump aiomealie to 1.1.1 and statically define mealplan entry types #158907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aiomealie to 1.1.1 and statically define mealplan entry types #158907
Conversation
|
Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Mealie integration to support new meal plan types introduced in Mealie 3.7.0 (snack, drink, dessert) by bumping the aiomealie library to version 1.1.1. To maintain backward compatibility, the integration intentionally restricts calendar entities to only the four meal plan types supported by all Mealie versions (breakfast, lunch, dinner, side). A future PR will add version-specific support for the new types.
Key changes:
- Bumps aiomealie dependency from 1.1.0 to 1.1.1 to prevent errors when new meal plan types are encountered
- Restricts calendar entity creation to four universally supported meal plan types
- Updates test fixtures and snapshots to include new meal plan types and verify they are properly handled but not displayed as calendar entities
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/mealie/calendar.py | Adds static list of supported meal plan types to limit calendar entity creation to breakfast, lunch, dinner, and side |
| homeassistant/components/mealie/manifest.json | Updates aiomealie requirement from 1.1.0 to 1.1.1 |
| requirements_all.txt | Updates aiomealie version to 1.1.1 |
| requirements_test_all.txt | Updates aiomealie version to 1.1.1 |
| tests/components/mealie/fixtures/get_mealplans.json | Updates test fixtures to include new meal plan types (dessert, drink, snack) |
| tests/components/mealie/fixtures/get_mealplan_today.json | Updates test fixtures to include new meal plan types (dessert, drink, snack) |
| tests/components/mealie/snapshots/test_calendar.ambr | Updates snapshots to verify new meal plan types are excluded from calendar entities |
| tests/components/mealie/snapshots/test_diagnostics.ambr | Updates snapshots to reflect new meal plan type categories in diagnostics data |
| tests/components/mealie/snapshots/test_services.ambr | Updates snapshots to reflect new meal plan entry types in service responses |
Proposed change
Version 3.7.0 of Mealie added additional meal plan types (snack, drink, and dessert) which if a recipe was added to any of these it would cause an error and stop the integration working.
This PR bumps aiomealie to 1.1.1 to support the additional meal plan types.
It also changes to a statically defined list of meal plan types to just those supported by all Mealie versions (breakfast, lunch, dinner, side).
Test fixtures have been modified to include the new meal plan types to ensure that calendars are not created and tests pass.
A future PR will perform version checking and add relevant meal plan types for the specific version.
joostlek/python-mealie@v1.1.0...v1.1.1
Please tag for the next 2025.12 milestone
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: