Skip to content

Conversation

@andrew-codechimp
Copy link
Contributor

@andrew-codechimp andrew-codechimp commented Dec 13, 2025

Proposed change

Version 3.7.0 of Mealie added additional meal plan types (snack, drink, and dessert) which if a recipe was added to any of these it would cause an error and stop the integration working.

This PR bumps aiomealie to 1.1.1 to support the additional meal plan types.
It also changes to a statically defined list of meal plan types to just those supported by all Mealie versions (breakfast, lunch, dinner, side).
Test fixtures have been modified to include the new meal plan types to ensure that calendars are not created and tests pass.

A future PR will perform version checking and add relevant meal plan types for the specific version.

joostlek/python-mealie@v1.1.0...v1.1.1

Please tag for the next 2025.12 milestone

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (mealie) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mealie can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mealie Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Mealie integration to support new meal plan types introduced in Mealie 3.7.0 (snack, drink, dessert) by bumping the aiomealie library to version 1.1.1. To maintain backward compatibility, the integration intentionally restricts calendar entities to only the four meal plan types supported by all Mealie versions (breakfast, lunch, dinner, side). A future PR will add version-specific support for the new types.

Key changes:

  • Bumps aiomealie dependency from 1.1.0 to 1.1.1 to prevent errors when new meal plan types are encountered
  • Restricts calendar entity creation to four universally supported meal plan types
  • Updates test fixtures and snapshots to include new meal plan types and verify they are properly handled but not displayed as calendar entities

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
homeassistant/components/mealie/calendar.py Adds static list of supported meal plan types to limit calendar entity creation to breakfast, lunch, dinner, and side
homeassistant/components/mealie/manifest.json Updates aiomealie requirement from 1.1.0 to 1.1.1
requirements_all.txt Updates aiomealie version to 1.1.1
requirements_test_all.txt Updates aiomealie version to 1.1.1
tests/components/mealie/fixtures/get_mealplans.json Updates test fixtures to include new meal plan types (dessert, drink, snack)
tests/components/mealie/fixtures/get_mealplan_today.json Updates test fixtures to include new meal plan types (dessert, drink, snack)
tests/components/mealie/snapshots/test_calendar.ambr Updates snapshots to verify new meal plan types are excluded from calendar entities
tests/components/mealie/snapshots/test_diagnostics.ambr Updates snapshots to reflect new meal plan type categories in diagnostics data
tests/components/mealie/snapshots/test_services.ambr Updates snapshots to reflect new meal plan entry types in service responses

@joostlek joostlek added this to the 2025.12.4 milestone Dec 13, 2025
@joostlek joostlek merged commit 2c29340 into home-assistant:dev Dec 13, 2025
63 checks passed
@andrew-codechimp andrew-codechimp deleted the mealie-dependency-bump branch December 13, 2025 21:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants