Assume cover or valve is always "running" in google assistant when the state is assumed or the position is reported to allow it to be be stopped #158919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Google assistant allows to stop or toggle a cover using the start/stop trait.
In case a cover or valve reports position, or when the state is assumed, the cover or valve state will not alway be
closingoropening. In that case we do not know the current state till it is reported again.This PR will change the behavior for the start/stop trait introduced with #106139 for entities that report a state or have an assumed state. For these these entities only the Stop button will show, as we assume the valve or cover is running, be cause we always want to to expose the Stop function in these cases.
If have seen this causes an issue when trying to stop a Zwave cover that reports position.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: