Skip to content

Conversation

@pantherale0
Copy link
Contributor

@pantherale0 pantherale0 commented Dec 15, 2025

Proposed change

When I bumped to 2.0.0, I introduced a regression in the refresh token logic. I had not caught this as at the time the library itself did not contain any sort of automated testing. Recent versions of the library has a full test suite now and token refreshes are now fully tested.

pynintendoauth has been bumped to its tested and compatible version

Release: https://github.com/pantherale0/pynintendoauth/releases/tag/1.0.2
Diff: pantherale0/pynintendoauth@1.0.0...1.0.2

Release: https://github.com/pantherale0/pynintendoparental/releases/tag/2.1.3
Diff: pantherale0/pynintendoparental@2.1.1...2.1.3

Can we include this and the following PRs in 2025.12.4? It would help tidy up my mailbox as I'm getting a new email about the update_required error quite a bit. No worries if not.

#158285
#158487
#158779

Apologies for missing this!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • ]X] There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@pantherale0 pantherale0 marked this pull request as draft December 15, 2025 16:49
@pantherale0 pantherale0 changed the title bump pynintendoparental 2.1.2 bump pynintendoparental 2.1.3 Dec 15, 2025
@pantherale0 pantherale0 force-pushed the bump/pynintendoparental212 branch from f5e74a9 to 1123f2c Compare December 15, 2025 17:23
@pantherale0 pantherale0 marked this pull request as ready for review December 15, 2025 17:26
@abmantis abmantis changed the title bump pynintendoparental 2.1.3 Bump pynintendoparental 2.1.3 Dec 15, 2025
@abmantis abmantis added this to the 2025.12.4 milestone Dec 15, 2025
@abmantis abmantis merged commit 9ba252d into home-assistant:dev Dec 16, 2025
67 checks passed
@pantherale0
Copy link
Contributor Author

Thanks @abmantis - can you tag the other PRs for 2025.12.4 too please? This one can't be merged without those.

@abmantis
Copy link
Member

Thanks @abmantis - can you tag the other PRs for 2025.12.4 too please? This one can't be merged without those.

Thanks for pointing that out, I had missed them. Added to the milestone now. Let me know if I missed something.

@pantherale0
Copy link
Contributor Author

Thank you :) appreciate it

heindrichpaul pushed a commit to heindrichpaul/core that referenced this pull request Dec 17, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants