Add availability to opentherm_gw entities #32408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Failed tests seem unrelated. Can anyone confirm? |
Contributor
MartinHjelmare
requested changes
Apr 1, 2020
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good! Just a small clean up.
| @callback | ||
| def receive_report(self, status): | ||
| """Receive and handle a new report from the Gateway.""" | ||
| self._available = status != {} |
Member
There was a problem hiding this comment.
Suggested change
| self._available = status != {} | |
| self._available = bool(status) |
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion, I will take care of it tomorrow.
Contributor
Author
|
Comment addressed and rebased on latest dev. |
Member
|
Test failures are unrelated as noted above. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Additional information
This PR adds support for detecting availability of the gateway and/or sensor data.
So far only
sensorandbinary_sensorentities will report whether or not their data is included in the status report. Theclimateentity is now prepared for support as well, but it will require an update of thepyotgwlibrary before it starts working. This update will be provided in a separate PR.Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: