Skip to content

Conversation

@balloob
Copy link
Member

@balloob balloob commented Apr 2, 2020

Breaking change

Proposed change

Convert the TTS test suite to async and use fixtures, minimize I/O and use aiohttp instead of requests.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @pvizeli, mind taking a look at this pull request as its been labeled with a integration (tts) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare merged commit b10319f into dev Apr 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the tts-async-tests branch April 2, 2020 16:55
@balloob balloob added this to the 0.108.0 milestone Apr 3, 2020
balloob added a commit that referenced this pull request Apr 3, 2020
* Convert TTS tests to async

* Address comments
@lock lock bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants