Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Apr 2, 2020

Proposed change

Bump HAP-python to 2.8.0

2.8.0 resolves a performance issue that could cause large setups
or installs with slow hardware to experience all homekit
accesories becoming unavailable.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco bdraco added this to the 0.108.0 milestone Apr 2, 2020
@bdraco
Copy link
Member Author

bdraco commented Apr 2, 2020

unrelated test failure

Bump HAP-python to 2.8.0

2.8.0 resolves a performance issue that could cause large setups
or installs with slow hardware to experience all homekit
accesories becoming unavailable.
@bdraco bdraco force-pushed the pyhap_homekit_unavailable_fix branch from f8fab6f to 2488492 Compare April 2, 2020 18:35
@bdraco
Copy link
Member Author

bdraco commented Apr 2, 2020

Tests are leaving files behind. Please update the tests to avoid writing any files:
tests/testing_config/.storage/core.config_entries

Unrelated CI issue

@springstan springstan changed the title Resolve homekit unavailable on slow hardware and large setups Bump HAP-python to 2.8.0 Apr 2, 2020
@springstan springstan merged commit 36a606f into home-assistant:dev Apr 2, 2020
balloob pushed a commit that referenced this pull request Apr 3, 2020
@lock lock bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants