Skip to content

Conversation

@ziv1234
Copy link
Contributor

@ziv1234 ziv1234 commented Apr 2, 2020

Breaking change

Not a breaking change

Proposed change

fix the mqtt unit tests to not throw exception. mock was missing a function

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

…sing an exception on the loop

now all mqtt tests pass
@probot-home-assistant probot-home-assistant bot added core has-tests small-pr PRs with less than 30 lines. labels Apr 2, 2020
@MartinHjelmare MartinHjelmare changed the title fix uncaught exceptions for mqtt Fix uncaught exceptions for mqtt Apr 2, 2020
@balloob balloob merged commit 8fbdc70 into home-assistant:dev Apr 2, 2020
@lock lock bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core has-tests small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix mqtt tests that have uncaught exceptions

3 participants