Skip to content

Conversation

@balloob
Copy link
Member

@balloob balloob commented Apr 8, 2020

Breaking change

Proposed change

The old version has been removed from PyPI, breaking our builds.

I don't know if this version works, but will upgrade anyway so our CI works again.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @TomerFi, mind taking a look at this pull request as its been labeled with a integration (switcher_kis) you are listed as a codeowner for? Thanks!

@frenck frenck added this to the 0.108.1 milestone Apr 8, 2020
@balloob
Copy link
Member Author

balloob commented Apr 8, 2020

Switcher KIS tests pass locally. Going to merge this .

@balloob balloob merged commit 5ff50e8 into dev Apr 8, 2020
@balloob balloob deleted the bump-switcher branch April 8, 2020 18:13
@frenck frenck removed this from the 0.108.1 milestone Apr 8, 2020
@TomerFi
Copy link
Contributor

TomerFi commented Apr 9, 2020

I'm sorry.
That's my bad!

I was working on a couple of modifications,
All of which are from a project management/ci-cd perspectives,
Absolutely no code modifications, so both versions works the same.

One of the changes was switching from calver to semver and I accidentally deleted the 2019.4.26 which was used by Home Assistant before I had a chance to pr the version update myself.

Sorry, thanks!

@frenck
Copy link
Member

frenck commented Apr 9, 2020

So this is safe to ship in a patch release @TomerFi?

@TomerFi
Copy link
Contributor

TomerFi commented Apr 9, 2020

Yes, it absolutely is.

@frenck frenck added this to the 0.108.2 milestone Apr 9, 2020
balloob added a commit that referenced this pull request Apr 10, 2020
@balloob balloob mentioned this pull request Apr 10, 2020
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants