Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Apr 9, 2020

Proposed change

  • HS220 dimmers are handled as lights with a limited feature set

  • Dimmers look up has has_emeter every call so this is cached as well now
    to resovle the performance issue.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

* HS220 dimmers are handled as lights with a limited feature set

* Dimmers look up has has_emeter every call so this is cached as well now
to resovle the performance issue.
@probot-home-assistant
Copy link

Hey there @rytilahti, mind taking a look at this pull request as its been labeled with a integration (tplink) you are listed as a codeowner for? Thanks!

@bdraco
Copy link
Member Author

bdraco commented Apr 9, 2020

#33909 merged before the device showed up. Had to chance a key and cache the emeter setting.

@bdraco
Copy link
Member Author

bdraco commented Apr 9, 2020

@rytilahti on the up side, I now have enough of these devices that I can test properly when you get your async version going!

@bdraco bdraco added this to the 0.108.2 milestone Apr 9, 2020
@balloob balloob merged commit a000af5 into home-assistant:dev Apr 10, 2020
balloob pushed a commit that referenced this pull request Apr 10, 2020
* HS220 dimmers are handled as lights with a limited feature set

* Dimmers look up has has_emeter every call so this is cached as well now
to resovle the performance issue.
@balloob balloob mentioned this pull request Apr 10, 2020
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants