Skip to content

Conversation

@Quentame
Copy link
Member

@Quentame Quentame commented Apr 22, 2020

Breaking change

Remove api_version config param

Proposed change

Bump python-synology to 0.7.0

https://github.com/ProtoThis/python-synology/releases/tag/0.7.0

It adds API discovery + DSM version dicovery + uses Exceptions instead of catching everything and returning None.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @ProtoThis, mind taking a look at this pull request as its been labeled with a integration (synology_dsm) you are listed as a codeowner for? Thanks!

@Quentame Quentame force-pushed the synology_dsm/bump branch from 4c5936e to 9d24e67 Compare April 22, 2020 16:42
@Quentame Quentame requested a review from bdraco April 22, 2020 16:45
@Quentame Quentame marked this pull request as ready for review April 22, 2020 16:45
@Quentame
Copy link
Member Author

Tested on DSM 6

  • working cases:
    • non 2SA
    • with 2SA
  • not working cases:
    • wrong credentials
    • wrong host
    • wrong port
    • wrong ssl

Everything is fine 👌 🎉

@Quentame
Copy link
Member Author

Quentame commented Apr 22, 2020

Just removed the api_version from the doc in this PR : home-assistant/home-assistant.io#13133

@bdraco
Copy link
Member

bdraco commented Apr 22, 2020

Will test later today when things are less busy

@Quentame
Copy link
Member Author

I hoped for a 0.109.0 to avoid an other breaking change on 0.110.0, but sure time is short now 😬

@balloob balloob added this to the 0.109.0 milestone Apr 22, 2020
@bdraco
Copy link
Member

bdraco commented Apr 22, 2020

@Quentame Did light testing and everything appears to be working. I don't have a v5 box anymore so I can only verify v6

@bdraco
Copy link
Member

bdraco commented Apr 22, 2020

Tested with two different boxes. No issues

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Quentame nice cleanup

@bdraco bdraco merged commit a8cd720 into home-assistant:dev Apr 22, 2020
@Quentame Quentame deleted the synology_dsm/bump branch April 22, 2020 21:29
balloob pushed a commit that referenced this pull request Apr 23, 2020
@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants