-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
Bump python-synology to 0.7.0 #34534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey there @ProtoThis, mind taking a look at this pull request as its been labeled with a integration ( |
e764c86 to
4c5936e
Compare
4c5936e to
9d24e67
Compare
Tested on DSM 6
Everything is fine 👌 🎉 |
|
Just removed the |
|
Will test later today when things are less busy |
|
I hoped for a 0.109.0 to avoid an other breaking change on 0.110.0, but sure time is short now 😬 |
|
@Quentame Did light testing and everything appears to be working. I don't have a v5 box anymore so I can only verify v6 |
|
Tested with two different boxes. No issues |
bdraco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Quentame nice cleanup
Breaking change
Remove
api_versionconfig paramProposed change
Bump python-synology to 0.7.0
https://github.com/ProtoThis/python-synology/releases/tag/0.7.0
It adds API discovery + DSM version dicovery + uses Exceptions instead of catching everything and returning None.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: