Skip to content

Conversation

@jjlawren
Copy link
Contributor

Breaking change

The "name" config option marked as deprecated in 0.107 will now cause errors on startup if still in the configuration.

Proposed change

Remove unused and deprecated configuration option.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @cereal2nd, mind taking a look at this pull request as its been labeled with a integration (cert_expiry) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare merged commit 813e945 into home-assistant:dev Apr 24, 2020
@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
@jjlawren jjlawren deleted the cert_expiry_109_deprecation_removal branch May 31, 2022 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants