Skip to content

Python 3.8 on CI #34654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Apr 25, 2020
Merged

Python 3.8 on CI #34654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
401b90c
Add python3.8 CI
pvizeli Apr 24, 2020
c8a2872
Fix tab/space
pvizeli Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
FROM python:3.7
FROM python:3.8

RUN apt-get update \
&& apt-get install -y --no-install-recommends \
RUN \
&& apt-get update && apt-get install -y --no-install-recommends \
Copy link
Contributor

@coreGreenberet coreGreenberet Apr 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&& should be removed from the beginning of this line -> can't build container

Copy link
Contributor

@jbergler jbergler Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also running into both these issues.
It's unclear to me why the ppa was added, since none of the installed packages live in the ppa.

Copy link
Contributor

@jbergler jbergler Apr 27, 2020 •
edited by balloob
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #34747 with fixes.

Copy link
Contributor

@coreGreenberet coreGreenberet Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks =)
yeah I wasn't sure why it got added there. Maybe it was an purpose. Thats why I've asked to fix it instead of creating a PR with removing it^^

software-properties-common \
&& add-apt-repository ppa:jonathonf/ffmpeg-4 \
Copy link
Contributor

@coreGreenberet coreGreenberet Apr 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When building the container I'm getting this back
E: The repository 'http://ppa.launchpad.net/jonathonf/ffmpeg-4/ubuntu groovy Release' does not have a Release file.

&& apt-get update && apt-get install -y --no-install-recommends \
libudev-dev \
libavformat-dev \
libavcodec-dev \
Expand Down
Loading