Skip to content

Fix unknown exception being caught in roomba config flow #35005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danielhiversen merged 1 commit into from
May 1, 2020
Merged

Fix unknown exception being caught in roomba config flow #35005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions homeassistant/components/roomba/config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ async def async_step_user(self, user_input=None):
info = await validate_input(self.hass, user_input)
except CannotConnect:
errors = {"base": "cannot_connect"}
except Exception: # pylint: disable=broad-except
errors = {"base": "unknown"}

if "base" not in errors:
await async_disconnect_or_timeout(self.hass, info[ROOMBA_SESSION])
Expand Down
1 change: 0 additions & 1 deletion homeassistant/components/roomba/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
}
},
"error": {
"unknown": "Unexpected error",
"cannot_connect": "Failed to connect, please try again"
}
},
Expand Down