Skip to content

Conversation

@Kane610
Copy link
Member

@Kane610 Kane610 commented May 2, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@Kane610 Kane610 self-assigned this May 2, 2020
@Kane610 Kane610 added this to the 0.109.3 milestone May 2, 2020
@Kane610
Copy link
Member Author

Kane610 commented May 2, 2020

Added milestone 0.109.3 don't know if this is really eligible for point release or should await 0.110.

@balloob balloob merged commit a2048b4 into home-assistant:dev May 2, 2020
@Kane610 Kane610 deleted the unifi-config_flow_no_local_user branch May 2, 2020 21:29
balloob pushed a commit that referenced this pull request May 2, 2020
@balloob balloob mentioned this pull request May 2, 2020
@lock lock bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unifi - Unknown error connecting with UniFi controller: 'role'

3 participants