Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented May 2, 2020

Proposed change

Improve stability of homekit media players

  • Prevent invalid names from causing homekit crashes

  • We were creating switches with "Play/Pause" in the name
    and "/" is an invalid name character

  • Avoid setting up TV inputs when there are no sources
    as it causes a crash on iOS 12

  • Auto detect media player features when they
    are not configured

  • Two places in media_player.py were setting the
    value to None when it should be a bool

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

* Prevent invalid names from causing homekit crashes

* We were creating switches with "Play/Pause" in the name
and "/" is an invalid name character

* Avoid setting up TV inputs when there are no sources
as it causes a crash on iOS 12

* Auto detect media player features when they
are not configured
@bdraco
Copy link
Member Author

bdraco commented May 2, 2020

This won't backport cleanly as accessory mappings are now in accessory.py and they used to be in __init__.py. If unsure on the cherry pick I can make a PR to rc or defer fixing this until 0.110

@balloob
Copy link
Member

balloob commented May 2, 2020

Thanks. I'll let you know if I need help with the cherry picking :)

@balloob balloob merged commit 4de30ca into home-assistant:dev May 2, 2020
@balloob balloob mentioned this pull request May 2, 2020
@lock lock bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homekit Integration: Lots of components disappeared...

3 participants