Skip to content

Conversation

@ludeeus
Copy link
Member

@ludeeus ludeeus commented May 3, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (websocket_api) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good view 😄

Should we fix it in 0.109.X ?

@Quentame Quentame merged commit de7f82e into dev May 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the ludeeus/websocket/typo branch May 3, 2020 09:36
@ludeeus ludeeus added this to the 0.109.4 milestone May 3, 2020
@ludeeus
Copy link
Member Author

ludeeus commented May 3, 2020

Added it to the milestone, but this is just a cosmetic change, so it's not a big deal if it's not added until 0.110

@Quentame
Copy link
Member

Quentame commented May 3, 2020

Yeah, but still can avoid people creating issue for it

balloob pushed a commit that referenced this pull request May 5, 2020
@balloob balloob mentioned this pull request May 5, 2020
@lock lock bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor cosmetic errors on Info page.

5 participants