Skip to content

Bump H11 library to support non RFC line endings #44735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jan 1, 2021

Breaking change

Proposed change

HTTPx only expects H11 to be of version v0.*, pin to v0.12.0 to make sure to get the new fix.
Code fix python-hyper/h11#115
Library bump python-hyper/h11@v0.11.0...v0.12.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 requested a review from bdraco January 1, 2021 15:11
@Kane610 Kane610 added this to the 2021.1.0 milestone Jan 1, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610!

Happy New Year 🥂

@frenck frenck merged commit c4fbfc2 into home-assistant:dev Jan 1, 2021
@Kane610
Copy link
Member Author

Kane610 commented Jan 1, 2021

Happy new years @frenck! 🥂 🍾

@Kane610 Kane610 deleted the bump_h11_to_resolve_non_rfc_endings branch January 1, 2021 18:11
@MartinHjelmare
Copy link
Member

MartinHjelmare commented Jan 1, 2021

Just a side note about github issue linking: To auto close more than one linked issue, each issue needs to be prefixed with fixes or closes etc.

@frenck
Copy link
Member

frenck commented Jan 1, 2021

Right! I missed that as well. Thanks Martin!

@Kane610
Copy link
Member Author

Kane610 commented Jan 1, 2021

Thanks @MartinHjelmare I've been wondering why it didn't work as I expected it to

@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axis-41 not working anymore since 0.117.0b0 / httpx
4 participants