Skip to content

Conversation

@emontnemery
Copy link
Contributor

@emontnemery emontnemery commented May 4, 2021

Proposed change

Add sensor state_class property as proposed in home-assistant/architecture#557
Use state_class property in philips_hue integration
Also, some minor typing improvements for sensor, can be moved to a separate PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@pvizeli
Copy link
Member

pvizeli commented May 4, 2021

👍 LGTM - I think the best future approved choice

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Member

We should update the developer docs.

@emontnemery
Copy link
Contributor Author

Developer docs PR: home-assistant/developers.home-assistant#922

@emontnemery emontnemery merged commit ba284c0 into home-assistant:dev May 7, 2021
@balloob
Copy link
Member

balloob commented May 7, 2021

Let's write a blog post for the dev blog about this so more integration authors are aware. We should also update our quality scale requirements.

@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants