-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
Add sensor state_class property #50063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensor state_class property #50063
Conversation
|
👍 LGTM - I think the best future approved choice |
Co-authored-by: Paulus Schoutsen <[email protected]>
MartinHjelmare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
We should update the developer docs. |
|
Developer docs PR: home-assistant/developers.home-assistant#922 |
|
Let's write a blog post for the dev blog about this so more integration authors are aware. We should also update our quality scale requirements. |
Proposed change
Add sensor
state_classproperty as proposed in home-assistant/architecture#557Use
state_classproperty in philips_hue integrationAlso, some minor typing improvements for
sensor, can be moved to a separate PR.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: