-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
Refactor MQTT discovery #67966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor MQTT discovery #67966
Conversation
|
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( |
763e2fd to
0b97afc
Compare
61eca2b to
8dc9fc8
Compare
b9d1ee8 to
cfb93b0
Compare
337fb99 to
aaee2f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is not done, when does the loop of device registry updates happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the comment to # Prevent a second cleanup round after the device is removed. Normally the device is cleaned up after an empty discovery payload. If the device is removed, all linked services are removed, that might cause multiple events. Only the first should trigger a cleanup.
Co-authored-by: Erik Montnemery <[email protected]>
Co-authored-by: Erik Montnemery <[email protected]>
Co-authored-by: Erik Montnemery <[email protected]>
Co-authored-by: Erik Montnemery <[email protected]>
31b86bd to
0975aad
Compare
emontnemery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @jbouwh 👍
Proposed change
async_removed_from_deviceto filter the correct event to remove a device.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: