Skip to content

Conversation

@ludeeus
Copy link
Member

@ludeeus ludeeus commented Aug 25, 2021

Breaking change

Proposed change

Show history graph for entities without a unit if a state_class is defined

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus merged commit a93222d into dev Aug 25, 2021
@ludeeus ludeeus deleted the show-history-graph-for-stateclass branch August 25, 2021 11:41

const stateWithUnit = stateInfo.find(
(state) => state.attributes && "unit_of_measurement" in state.attributes
const stateWithUnitorStateClass = stateInfo.find(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not be written as stateWithUnitOrStateClass?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants