Repository navigation
feat!: serve health on the main port; metrics port becomes fully optional - #52
Merged
Merged
Conversation
…onal Adopt the org port standard for primary-HTTP apps: /healthz (liveness) and /readyz (readiness, an alias today) live on the main webhook port (8080) and the chart's probes target the http port, so the metrics listener (8081) is metrics-only and truly optional — CHASKI_METRICS_ENABLED=false removes the listener, container port, Service port, and ServiceMonitor without touching the probes. The helm test hook now checks /readyz on the Service http port. BREAKING CHANGE: the metrics listener no longer serves /healthz; external probe/scrape configs pointing at :8081/healthz must move to the http port (/healthz or /readyz). In-chart probes and the ServiceMonitor are updated automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollout PR #2 of the org metrics/health standard (primary-HTTP tier + the
/healthz+/readyzpair).What changed
/healthz(liveness) +/readyz(readiness) on the main webhook port (8080). readyz aliases healthz today — the endpoint exists so probes and external configs never change if chaski ever gains a real serving condition. (This also retires the long-standing wart of/readyzappearing in the debug-log path map without being served.)httpport (liveness+startup →/healthz, readiness →/readyz). New chart test pins thatmetricsEnabled: falseremoves the metrics containerPort while probes still resolve./readyzon the Service http port instead ofmetricsPort/healthz.CHASKI_METRICS_PORTstays a port int bound":<port>"(already dual-stack safe).Compatibility
:8081/healthzmust move to the http port — hencefeat!.go test -racegreen, lint 0 issues,helm lint+helm unittest(20/20) green, docs/schema regenerated,helm template --set config.metricsEnabled=falserenders no metrics port and http-targeted probes.Prior PR in the rollout: home-operations/echo#28. Next: kromgo, konflate, then tuppr/litellm-operator/miroir, then drm-exporter.