Skip to content

feat!: drop the legacy /-/health and /-/ready aliases #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onedr0p merged 1 commit into from
Jul 4, 2026
Merged

feat!: drop the legacy /-/health and /-/ready aliases #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions internal/server/health.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@ import (

// healthPaths are the liveness/readiness endpoints, served on the MAIN port
// (the org pair standard: /healthz = liveness, /readyz = readiness — aliases
// here, kromgo has no serving condition beyond being up). The /-/ variants are
// kept for backward compatibility.
var healthPaths = []string{"/healthz", "/readyz", "/-/health", "/-/ready"}
// here, kromgo has no serving condition beyond being up).
var healthPaths = []string{"/healthz", "/readyz"}

// withHealth overlays the health endpoints onto the application handler, so
// probes work regardless of whether the optional metrics listener is enabled.
Expand Down
2 changes: 1 addition & 1 deletion internal/server/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func TestWithHealth(t *testing.T) {
appHit = true
w.WriteHeader(http.StatusOK)
}))
for _, path := range []string{"/healthz", "/readyz", "/-/health", "/-/ready"} {
for _, path := range []string{"/healthz", "/readyz"} {
t.Run(path, func(t *testing.T) {
req := httptest.NewRequest(http.MethodGet, path, nil)
w := httptest.NewRecorder()
Expand Down
Loading