Skip to content

fix: raise a pull request before automerging - #63

Closed
onedr0p wants to merge 1 commit into
mainfrom
fix/renovate-pr-automerge
Closed

onedr0p wants to merge 1 commit into
mainfrom
fix/renovate-pr-automerge

Conversation

@onedr0p

@onedr0p onedr0p commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Overview

Swaps :automergeBranch for :automergePr in config/baseConfig.json5.

Additional information

:automergeBranch is {"automergeType": "branch"} — when a rule sets
automerge: true, Renovate pushes the commit straight to the base branch with
no pull request.

Unlike home-operations/renovate-config#39, where the preset is currently inert,
this repo is actually affected. Its own .renovaterc.json5 extends:

":automergeMinor",   // automerge: true for minor, patch, pin, lockFileMaintenance
":automergeDigest",  // automerge: true for digest

so those update types have automerge: true while inheriting automergeType: branch from config/baseConfig.json5 — i.e. they are eligible to land on main
without a pull request.

validate.yaml only runs on pull_request and pushes to main, so a Renovate
branch carries no status checks for branch automerge to gate on either way.

Validated with renovate-config-validator --strict against all 19 files.
Regenerating default.json produces no diff, since it is a list of preset file
references rather than inlined content.

Note

CI on this branch will be red for the same pre-existing reason as
#62 — mise 2026.7.13 rejects
npm:renovate@43.280.1 on a supply-chain trust check during Setup Mise.
That has been failing on main since before this branch existed.

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: YES — change and description written by an AI agent (Claude Code) under maintainer direction.

Swaps :automergeBranch for :automergePr. Branch automerge pushes the new
commit straight to the base branch with no pull request.

Unlike the other preset bundle, this is live rather than latent: this
repo's own .renovaterc.json5 extends :automergeMinor and :automergeDigest,
so minor, patch, pin, lockFileMaintenance and digest updates all set
automerge: true while inheriting branch automerge from the base config.

validate.yaml only runs on pull_request and pushes to main, so a Renovate
branch carries no status checks for branch automerge to wait on.

Signed-off-by: Devin Buhl <devin@buhl.casa>
@greptile-apps

greptile-apps Bot commented Jul 25, 2026

Copy link
Copy Markdown

Greptile Summary

This PR changes the base Renovate preset to use pull-request automerging instead of direct branch automerging.

  • Replaces :automergeBranch with :automergePr.
  • Ensures automerge-enabled updates create pull requests before merging.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable correctness or security issues identified.

The preset replacement preserves automerge behavior while changing its delivery path from direct base-branch updates to pull-request-based merging.

T-Rex T-Rex Logs

What T-Rex did

  • The changed base preset was validated against a single file.
  • The complete bundle of 19 files was validated successfully.
  • Validation logs for both runs, including commands, file lists, stdout, stderr, working directories, and exit statuses, were archived and reviewed.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
config/baseConfig.json5 Replaces the branch automerge preset with the PR automerge preset; no actionable issues identified.

Reviews (1): Last reviewed commit: "fix: raise a pull request before automer..." | Re-trigger Greptile

@onedr0p

onedr0p commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

Closing — wrong target.

config/baseConfig.json5 is the published preset, so flipping :automergeBranch
here changes automerge behaviour for external consumers of this bundle. I
checked the whole org and every repo extends home-operations/renovate-config;
the only reference to renovate-presets is this repo pointing at itself. So the
change carries downstream cost and no internal benefit.

home-operations/renovate-config#39 is the one that matters — that is the default
the other 23 repos inherit.

@onedr0p onedr0p closed this Jul 25, 2026
@onedr0p
onedr0p deleted the fix/renovate-pr-automerge branch July 25, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant