-
Notifications
You must be signed in to change notification settings - Fork 88
fix: Deterministic sort list in output to avoid random order #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tonur
wants to merge
12
commits into
homeport:main
Choose a base branch
from
tonur:deterministic-sort-list-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce it was used everywhere else
Author
|
I don't know if this is a fix or a feat. |
Author
|
Any chance that this could get a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves one part of this issue:
dyff betweencommand is non deterministic and uses 2 different styles randomly #525With some additional features added to solve machine readable feature request in this PR:
YAML comparison to avoid non-deterministic random output:
getNonStandardIdentifierFromNamedListsfunction inpkg/dyff/core.gonow sorts keys before iterating, ensuring deterministic order when comparing named lists. This prevents inconsistent results due to map iteration order.Test fixture updates:
assets/issues/issue-525/from.yamlandassets/issues/issue-525/to.yamlhave been updated with new and modified entries, reflecting changes in image tags, digests, and additional images for more comprehensive testing. [1] [2]Output formatting:
generateHumanDetailOutputAdditionmethod inpkg/dyff/output_human.gonow uses the report's configured indent value instead of a hardcoded value, ensuring consistent output formatting.Example that this is deterministic:

One sample:
Many samples:
