feat: implement OGC API Features landing page and conformance (#15)

[mikemcdougall]

Summary

• Implements OGC API Features Core landing page endpoint (GET /ogc/features)
• Implements conformance declaration endpoint (GET /ogc/features/conformance)
• Establishes foundation for OGC API Features specification compliance
• Provides comprehensive test coverage for core OGC endpoints

Technical Implementation

• Landing Page: Returns JSON with links to API definition, conformance, and collections
• Conformance Declaration: Lists all supported OGC API Features conformance classes
• Link Generation: Dynamic base URL construction from HTTP context
• Caching: Configured with appropriate cache policies for metadata endpoints

OGC Compliance

✅ OGC API Features Core:

• http://www.opengis.net/spec/ogcapi-features-1/1.0/conf/core
• http://www.opengis.net/spec/ogcapi-features-1/1.0/conf/oas30
• http://www.opengis.net/spec/ogcapi-features-1/1.0/conf/html
• http://www.opengis.net/spec/ogcapi-features-1/1.0/conf/geojson

✅ OGC API Common:

• http://www.opengis.net/spec/ogcapi-common-1/1.0/conf/core
• http://www.opengis.net/spec/ogcapi-common-1/1.0/conf/landing-page
• http://www.opengis.net/spec/ogcapi-common-2/1.0/conf/collections

Test Coverage

✅ Landing Page Tests:

• Valid response structure with required links
• Correct base URL construction
• Self, service-desc, conformance, and data links validation

✅ Conformance Tests:

• Required conformance classes verification
• Proper JSON structure validation

Architecture

• Vertical Slice: OGC features organized in dedicated namespace
• Models: Clean OGC-compliant data models with JSON serialization
• Caching: Output caching policies for metadata endpoints
• AOT Compatible: Uses proper JSON contexts and minimal APIs

Foundation for Future Work

This establishes the base for:

• Issue OGC Collections endpoint #16: Collections endpoint
• Issue OGC Items endpoint with bbox and filter #17: Items endpoint
• Future OGC API Features extensions

🤖 Generated with Claude Code

[github-actions]

🤖 LLM Architecture Review

⚠️ Assessment: NEEDS_ATTENTION

🏗️ Architecture Review Summary

✅ Good Patterns Found:

• Comprehensive XML documentation for public types in src/Honua.Server/Features/OgcFeatures/Models/OgcModels.cs:11 ensures clarity and maintainability.
• Use of immutable collections in models (ImmutableArray) in src/Honua.Server/Features/OgcFeatures/Models/OgcModels.cs:23 enhances thread safety and predictability.
• Minimal API pattern correctly implemented in src/Honua.Server/Features/OgcFeatures/OgcFeaturesEndpoints.cs:9 aligns with architectural guidelines to avoid legacy controller patterns.
• Proper use of dependency injection and configuration of services in src/Honua.Server/Program.cs adheres to clean architecture principles, ensuring a clear separation of concerns and scalability.

⚠️ Architecture Concerns:

• Potential Overlook in PR Process Compliance: The PR is linked to multiple issues which might dilute focus and lead to partial implementations. This needs clarification to ensure all linked issues' acceptance criteria are fully addressed. Severity: NEEDS ATTENTION

💡 Recommendations:

• Clarify PR Scope: Ensure that the PR title and description clearly state which issue's acceptance criteria are being addressed. This will help in tracking and validating feature completeness.
• Refactor for Single Responsibility: Consider breaking down the PR into smaller units that each address a single issue fully. This approach can improve manageability and traceability of changes.

// Suggested change in PR management
// Title: feat: Implement OGC API Features landing page (#15)
// Description: This PR fully implements the landing page as described in issue #15, including all acceptance criteria.

📚 Educational Notes:

• Importance of Immutable Collections: Using immutable collections like ImmutableArray in geospatial data models ensures that once a data structure is created, it cannot be altered unexpectedly, which is crucial for concurrent data processing and maintaining data integrity in a multi-threaded environment.
• Minimal APIs and Geospatial Performance: Adopting Minimal APIs reduces the overhead associated with traditional MVC controllers, leading to lighter, more performant services. This is particularly beneficial in geospatial applications where rapid processing and delivery of spatial data are critical.

Overall Assessment: NEEDS ATTENTION

CRITICAL: The PR appears to be linked correctly to GitHub issues, and there are acceptance criteria listed for the linked issues. However, it's not clear if all changes in the PR directly address the acceptance criteria of the linked issues. This needs further clarification to ensure full compliance with the PR process. If the PR does not fully address at least one complete set of acceptance criteria for an issue, it should be considered as having BLOCKING ISSUES.

---

Automated architectural analysis powered by OpenAI GPT-4
This review focuses on architectural patterns and design decisions
Human review still recommended for complex changes