Add nodes.json filters for domain and domain_fallback_site#186
Open
RobWei wants to merge 1 commit intohopglass:masterfrom
Open
Add nodes.json filters for domain and domain_fallback_site#186RobWei wants to merge 1 commit intohopglass:masterfrom
RobWei wants to merge 1 commit intohopglass:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the Gluon firmware comes with multidomain support, we have to determine the nodes of a community via the nodeinfo field "domain_code".
As an backwards compatible solution we need a "domain_fallback_site" filter to get all nodes that have not multidomain firmware yet.
The "domain_fallback_site"-Filter firstly tries to use the "domain_code" field and will fallback to the "site_code" field when not exists.