Skip to content

Conversation

@desertstsung
Copy link
Contributor

Update zsh completion file aligned to fish

@hpjansson
Copy link
Owner

Thanks! I'll merge this, but it's still missing a few options like --files, --files0, --label, --grid, --link, as far as I can tell.

@hpjansson hpjansson merged commit a2e09d2 into hpjansson:master Nov 27, 2025
1 check passed
@desertstsung
Copy link
Contributor Author

Thank you :)
Indeed, there are still some options missing both inside zsh and fish according to the source codes, but as you can see, this is my first PR of this repo, I can't tell if my changes follow its code-of-conduct, so the only refeerence was the fish completion file.
Maybe I can draft a fully documented zsh completion file if I grasp my time, and we can disccuss on it. BTW, I'm wondering if we also have a plan on bash completion? I think bash is more common than zsh/fish.

@hpjansson
Copy link
Owner

No problem. Your changes are fine.

Yes, if you have the time, I'd love to look at full zsh coverage. There's no plan for bash completions, but you're right: we do need one.

@hpjansson hpjansson mentioned this pull request Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants