Skip to content

Conversation

@desertstsung
Copy link
Contributor

Major changes:

  1. initialize a (local-tested) bash completion file, also mentioned in Bash completions #315. Should we also consider about informing the packagers when the next version release? or clearify this in the changelog. IDK
  2. update fish completion based the previous updated zsh comepletion.

Minor change:

  1. add noise option into dither arguments list, both in zsh and fish completion.

@desertstsung desertstsung changed the title Update completions files [Completion] Add bash completion and update fish completion Dec 9, 2025
@desertstsung desertstsung changed the title [Completion] Add bash completion and update fish completion tools: add bash completion and update fish completion Dec 9, 2025
@hpjansson
Copy link
Owner

Thanks, this is great. It's only missing the installation target in tools/completions/Makefile.am for bash. It should probably go to $(PREFIX)/bash-completion/completions/chafa.

(I just realized the target prefix is hardcoded to /usr/share, which is wrong. It should be set to ${datadir}, but that's for a different bug).

@desertstsung
Copy link
Contributor Author

desertstsung commented Dec 10, 2025

It's only missing the installation target in tools/completions/Makefile.am for bash.

Ah yes of course, it is so obvious in the folder! I didn't even open it for a look. OK, I'll do this later.

It should be set to ${datadir}

I don't have much exp on that, but after a search, I think it is worth to do and I can give a fix along with this PR :)

@hpjansson
Copy link
Owner

Looks good now. Thanks!

@hpjansson hpjansson merged commit 48b5611 into hpjansson:master Dec 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants