building fails on mac

[ouwou]

cant really test myself, but github actions gave me this:

  Error: /Users/runner/work/abaddon/abaddon/subprojects/keychain/src/keychain_mac.cpp:115:23: error: 'SecKeychainFindGenericPassword' is deprecated: first deprecated in macOS 10.10 - SecKeychain is deprecated [-Werror,-Wdeprecated-declarations]
      OSStatus status = SecKeychainFindGenericPassword(
                        ^
  /Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:628:10: note: 'SecKeychainFindGenericPassword' has been explicitly marked deprecated here
  OSStatus SecKeychainFindGenericPassword(CFTypeRef __nullable keychainOrArray,  UInt32 serviceNameLength, const char * __nullable serviceName, UInt32 accountNameLength, const char * __nullable accountName, UInt32 * __nullable passwordLength, void * __nullable * __nullable passwordData, SecKeychainItemRef * __nullable CF_RETURNS_RETAINED itemRef)
           ^

maybe a -Wno-error=deprecated-declarations would suffice?

keychain/CMakeLists.txt

Line 25 in f0e4d49

$<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -pedantic -Werror>)

[hrantzsch]

Indeed, thanks for letting me know. Unfortunately the API we're using is deprecated. As far as I know there's no replacement available that doesn't require Xcode, or at least some involved setup of App capabilities.