added style Menubutton, and finished sync #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got preview updating.
Added a Menubutton so the user can select light or dark style, updates the style in both text_area and preview_area
switched from Menu.post() to Menu.tk_popup() for better menu removal when no options are desired.
|
Hi @hbregalad and thanks for this brilliant PR ! The project is only about 15/16 hours old so i honestly wasn't expecting any other contributors, thank you ! The PR is good, i'll accept and merge, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a Menubutton added for selecting style,
connected style of text_area to style of preview_area via a self.css member field
added another flag reset of text_area.edit_modified so that on_input_change fires when it should.