Cannot find module ws, however ws is installed

[AddictArts]

Here is the error:

WS is installed to the that extensions/node ... node_modules folder.

C:\box\neu\neutralino-ext-node
❯ .\extensions\node\run.cmd .
Debugger listening on ws://127.0.0.1:9229/66645dff-2aea-4ae4-9ff6-477ab25fa42e
For help, see: https://nodejs.org/en/docs/inspector
---
NodeJS Version: v21.7.2
NodeJS Path: C:\box\neu\neutralino-ext-node\extensions\node\_runtime\nodejs-win\Scripts\node.exe
---
node:internal/modules/cjs/loader:1145
  throw err;
  ^

Error: Cannot find module 'ws'
Require stack:
- C:\box\neu\neutralino-ext-node\extensions\node\neutralino-extension.js
- C:\box\neu\neutralino-ext-node\extensions\node\main.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1142:15)
    at Module._load (node:internal/modules/cjs/loader:983:27)
    at Module.require (node:internal/modules/cjs/loader:1230:19)
    at require (node:internal/modules/helpers:179:18)
    at NeutralinoExtension.run (C:\box\neu\neutralino-ext-node\extensions\node\neutralino-extension.js:71:27)
    at Object.<anonymous> (C:\box\neu\neutralino-ext-node\extensions\node\main.js:53:5)
    at Module._compile (node:internal/modules/cjs/loader:1368:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1426:10)
    at Module.load (node:internal/modules/cjs/loader:1205:32)
    at Module._load (node:internal/modules/cjs/loader:1021:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    'C:\\box\\neu\\neutralino-ext-node\\extensions\\node\\neutralino-extension.js',
    'C:\\box\\neu\\neutralino-ext-node\\extensions\\node\\main.js'
  ]
}

Node.js v21.7.2

Thanks for the help.

[hschneider]

Sorry, this was not clear as it should be in the manual. Have fixed it now.

If you use embedded Node, you'll have to install the ws module as follows:

cd extensions\node
install.cmd
npm.cmd install ws

If you use a global Node-installation, then this is the way:

npm install ws --save

[AddictArts]

Thanks. Now I can run it using the run.cmd from a powershell prompt. However, the neu run cannot start it. Too bad we don't get anything in the log, or better feedback on whatever the error is. The rust example is now working and the curl one does as well. Thanks

[AddictArts]

Here is an example of running from the pwsh

C:\box\neu\neutralino-ext-node
❯ .\extensions\node\run.cmd .
Debugger listening on ws://127.0.0.1:9229/865fee1f-6e79-4035-a7b0-f4154f90a178
For help, see: https://nodejs.org/en/docs/inspector
---
NodeJS Version: v21.7.2
NodeJS Path: C:\box\neu\neutralino-ext-node\extensions\node\_runtime\nodejs-win\Scripts\node.exe
---
WebSocket Error: Error: connect ECONNREFUSED 127.0.0.1:80
WebSocket closed: 1006 -

For whatever reason neutralino is not starting node. I added the double backslash and that didn't resolve it like it did the rust. The socket error above is expected since neutralino is not running.

[AddictArts]

If this helps I see what is happening, captured stdout from the node process.

WebSocket closed: 1006 - 

[AddictArts]

So, it turns out for Windows at least these lines are what gets executed instead of reading from stdin the token etc,

        if(process.argv.length > 2) {
            this.port = process.argv[2].split('=')[1];
            this.token = process.argv[3].split('=')[1];
            this.connectToken = '';
            this.idExtension = process.argv[4].split('=')[1];
            this.urlSocket = `ws://127.0.0.1:${this.port}?extensionId=${this.idExtension}`;
        }

[AddictArts]

While now working, the node process spun up becomes a zombie process. Maybe this is only dev mode and not a build. Thanks for the help.

[hschneider]

WebSocket Error: Error: connect ECONNREFUSED 127.0.0.1:80

Port 80 should not be used for websockets. Set it to some port higher than 1024 or to 0, so it gets a random port.

If you start the extension manually with run.cmd, then it runs detached from the Neutralino main process. That's what you recognize as a zombie process.

[AddictArts]

WebSocket Error: Error: connect ECONNREFUSED 127.0.0.1:80

Port 80 should not be used for websockets. Set it to some port higher than 1024 or to 0, so it gets a random port.

If you start the extension manually with run.cmd, then it runs detached from the Neutralino main process. That's what you recognize as a zombie process.

Thanks, the process was started by neutralino. I think the argument count is different in Windows than Linux and it was trying to use the path you are pointing out, starting the extension manually. I do have it working now as intended. I will try and see what the argument count is under windows, my guess is greater than 2 for argv, thus it went into the if body.

[hschneider]

The args > %1 in run.cmd play no role in Neutralino 5. Meanwhile I was able to verify the behavior on a Windows machine. There seems to be something other broken under Windows. I see the Node process running, but the websocket connection seems to be dead.

I will dig further and keep you posted.

[hschneider]

Fixed it.

The problem was the -g flag in npm.cmd. It behaves different on macOS/Linux and Windows.

Replace all .cmd files in the extensions/node folder.
Then run

.\npm.cmd install ws

again.

BTW:
You might also have a look at the Bun Extension. It's nearly 100% NodeJS compatible and runs on Windows as well:
https://github.com/hschneider/neutralino-ext-bun

[AddictArts]

The args > %1 in run.cmd play no role in Neutralino 5.

I am getting a different count on Windows running the code as it was when I first made this issue.

process argv length 5

I had the node process log this in the constructor for the web socket. I am using v5, so there must be another explanation. Thanks again.

PS: I thought Bun on Windows was a joke, it was an April 1st release.

[hschneider]

Please replace all .cmd files and make sure that you use Neutralino 5.x.
Bun for Windows works since its last Beta, no April joke :-)

[AddictArts]

@hschneider The issue is this in the run.cmd is %2=%3 %4=%5 %6=%7 which turn into = = = when run as an extension.

Thus making the extra arguments, maybe you changed run.cmd, I didn't look. The next issue I have is node stays running on Windows even though in the socket close I added process.exit(). That is not your issue, just an observation.

[hschneider]

This has been removed. There are also changes in other files.
That's why you should replace all cmd files and reinstall the ws module.

[hschneider]

The Node process exists fine. I think this issue will solve itself, when you updated to the latest repo version.
I tested it on Win11 Pro with embedded NodeJS v21.5.0:

https://app.screencast.com/YKSr8F3KlNgCS