c_raii undefined behavior in dtor after move #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

kelbon opened this issue Dec 22, 2022 · 1 comment

Assignees

kelbon commented Dec 22, 2022

cppfront/include/cpp2util.h

Line 1007 in 2f37277

~c_raii() { dtor(t); }

Dctor invokes nullptr if c_raii object was moved.
Also its inefficient to store function pointer and not functional object + [[no_unqiue_address]]

Owner

hsutter commented Dec 22, 2022

Good point, simplest is to make it not movable. Thanks!

hsutter self-assigned this

hsutter closed this as completed in

3deb042

Azmah-Bad pushed a commit to Azmah-Bad/cppfront that referenced this issue


          Make c_raii non-movable, closes hsutter#176

e8d8264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment