Add support for static varaibles #213
Conversation
| @@ -519,6 +519,7 @@ struct type_id_node | |||
| { | |||
| source_position pos; | |||
|
|
|||
| token const* static_qualifier = {}; | |||
There was a problem hiding this comment.
[Explanation] I could have easily included static in pc_qualifiers (that could be renamed). I decided against that as static is of somewhat different nature.
There was a problem hiding this comment.
Yes, that's the way I tend to handle these qualifiers.
But I feel bad that I'm going to close this PR unmerged now, seeing all the work you've put into it -- as I mentioned on #212 I'm still thinking about what I want to do for static variables and I'd like to push them down the road, especially to get experience with classes first (and how the demands for static members unfolds there)... sorry, and thanks for understanding!
|
Closing for now per comment above and #212 -- thanks for understanding! I appreciate the work you put into this though and that you wrote the code thoughtfully and included lots of test cases. |
|
I understand and agree with your remarks. The work is not lost - I got to understand better how the code works. |
|
Now that I've caught up on issues and PRs (barring a new wave) I hope to be able to start looking at the next set of features... thanks again. |
This PR is my attempt at #212 with tests.