Skip to content

perf(io): refactor to not read line beyond the end of "import" #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

JohelEGP
Copy link
Contributor

@JohelEGP JohelEGP commented Jun 18, 2023

Implements #515 (comment).
Not a big deal, just optimizes the case where a line starts with a long identifier.

100% tests passed, 0 tests failed out of 668

Total Test time (real) =  92.99 sec

clang-12-libstdc++-e.cpp2... ok (all Cpp1)

real 0.38
user 0.37
sys 0.01
gcc-10-libstdc++-e.cpp2... ok (all Cpp1)

real 0.39
user 0.37
sys 0.01
msvc-msstl-e.cpp2... ok (all Cpp1)

real 0.53
user 0.52
sys 0.01

@hsutter hsutter merged commit 34b2af3 into hsutter:main Jun 18, 2023
@JohelEGP JohelEGP deleted the perf_io_import branch June 18, 2023 22:33
zaucy pushed a commit to zaucy/cppfront that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants