Skip to content

fix(cpp1): flank == with spaces to preserve meaning #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 28, 2023
Merged

fix(cpp1): flank == with spaces to preserve meaning #617

merged 4 commits into from
Aug 28, 2023

Conversation

JohelEGP
Copy link
Contributor

Resolves #524.

Testing summary:

100% tests passed, 0 tests failed out of 760

Total Test time (real) =  37.39 sec

Acknowledgements:

@hsutter
Copy link
Owner

hsutter commented Aug 28, 2023

Thanks!

@hsutter hsutter merged commit 1e6d740 into hsutter:main Aug 28, 2023
@JohelEGP JohelEGP deleted the max_munch branch August 28, 2023 23:18
zaucy pushed a commit to zaucy/cppfront that referenced this pull request Dec 5, 2023
@JohelEGP @zaucy
fix(cpp1): flank == with spaces to preserve meaning (hsutter#617)
21cf691 
* test: add `pure2-bugfix-for-max-munch`

* fix(cpp1): flank `==` with spaces to preserve meaning

* test: refactor to prevent warnings

* refactor: regenerate `reflect.h` and `regression-tests`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Not emitting Cpp2 space changes Cpp1 parsing due to max munch
2 participants
@JohelEGP @hsutter