[SUGGESTION] Add inspection of std::variant and std::optional values#86
Closed
filipsajdak wants to merge 4 commits intohsutter:mainfrom
Closed
[SUGGESTION] Add inspection of std::variant and std::optional values#86filipsajdak wants to merge 4 commits intohsutter:mainfrom
std::variant and std::optional values#86filipsajdak wants to merge 4 commits intohsutter:mainfrom
Conversation
8f3ecfd to
dd7d4a3
Compare
073a521 to
e4b0db9
Compare
Contributor
Author
|
Rebase to main. Make |
Contributor
Author
|
Might require #90 for some use cases. |
e4b0db9 to
58a2727
Compare
58a2727 to
95359ca
Compare
|
Conceptually can we make |
95359ca to
a9f26b4
Compare
Owner
|
Thanks! About half of this (parsing and literals) seems to be duplicated from #79, so I'll focus on the |
Owner
Owner
|
I've now added this with 2f37277 - thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of
inspectandisallows to inspect types. #79 add inspection capabilities to check values of variables (what allows to replace cpp1 switches).This change introduce possibility to inspect values stored in
std::variantandstd::optionalwhat make given code work:or you can use it as if statement with
std::optionalor
std::variantThis PR is based on #79