Skip to content

enable 2 UT cases on XPU#3445

Merged
SunMarc merged 8 commits intohuggingface:mainfrom
yao-matrix:xpu-2-cases
Mar 25, 2025
Merged

enable 2 UT cases on XPU#3445
SunMarc merged 8 commits intohuggingface:mainfrom
yao-matrix:xpu-2-cases

Conversation

@yao-matrix
Copy link
Contributor

@yao-matrix yao-matrix commented Mar 19, 2025 •
edited
Loading

  1. test_dispatch_model_tied_weights_memory_with_nested_offload_cpu
  2. test_dispatch_model_tied_weights_memory

enable test_dispatch_model_tied_weights_memory_with_nested_offload_cp…
b8cddd0 
…u test case on XPU

Signed-off-by: root <root@a4bf01945cfe.jf.intel.com>
@yao-matrix
Copy link
Contributor Author

yao-matrix commented Mar 19, 2025

@SunMarc , pls help review, thx

@yao-matrix yao-matrix changed the title enable test_dispatch_model_tied_weights_memory_with_nested_offload_cpu on XPU enable 2 cases on XPU Mar 19, 2025
@yao-matrix
fix style
5c884da 
Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
@yao-matrix
Copy link
Contributor Author

yao-matrix commented Mar 19, 2025

@faaany

@yao-matrix yao-matrix changed the title enable 2 cases on XPU enable 2 UT cases on XPU Mar 19, 2025
SunMarc
SunMarc approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM !

@SunMarc SunMarc requested a review from muellerzr March 19, 2025 14:10
yao-matrix and others added 3 commits March 19, 2025 10:18
@yao-matrix
enable test_dispatch_model_tied_weights_memory on XPU
a0091b8 
Signed-off-by: N <matrix.yao@intel.com>
fix bug
8c16cf2 
Signed-off-by: root <root@a4bf01945cfe.jf.intel.com>
@yao-matrix @SunMarc
Update src/accelerate/test_utils/testing.py
aa9c693 
Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 20, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

muellerzr
muellerzr reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's use getattr however to make this a bit more flexible should we support other options down the road

yao-matrix and others added 3 commits March 21, 2025 08:18
@yao-matrix @muellerzr
Update src/accelerate/test_utils/testing.py
c22b421 
Co-authored-by: Zach Mueller <muellerzr@gmail.com>
@yao-matrix @muellerzr
Update tests/test_big_modeling.py
4b830c9 
Co-authored-by: Zach Mueller <muellerzr@gmail.com>
@yao-matrix
fix style
547c854 
Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
@yao-matrix
Copy link
Contributor Author

yao-matrix commented Mar 23, 2025 •
edited
Loading

seems the CI failure is not triggered by my PR.

@yao-matrix
Copy link
Contributor Author

yao-matrix commented Mar 24, 2025

@muellerzr , pls help review and let me know what i can do, thx.

SunMarc
SunMarc approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! merging

@SunMarc SunMarc merged commit 8576112 into huggingface:main Mar 25, 2025
24 of 25 checks passed
@yao-matrix yao-matrix deleted the xpu-2-cases branch March 26, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SunMarc SunMarc SunMarc approved these changes

+1 more reviewer

@muellerzr muellerzr muellerzr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yao-matrix @HuggingFaceDocBuilderDev @muellerzr @SunMarc