Skip to content

Add FP8 runners + tweak building FP8 image#3493

Merged
SunMarc merged 28 commits intomainfrom
muellerzr-fp8-runner
Apr 15, 2025
Merged

Add FP8 runners + tweak building FP8 image#3493
SunMarc merged 28 commits intomainfrom
muellerzr-fp8-runner

Conversation

@zach-huggingface
Copy link
Contributor

What does this PR do?

This PR adds in running TE/FP8 tests through our dedicated CI runner for said tests.

Also tweaks the docker image to allow for us to request which CUDA NVIDIA image we use (so we can get the latest TE version of the month). By default it builds with the prior month's image (so we always build off of the "latest-ish" release.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc @S1ro1

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@S1ro1 S1ro1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunMarc
Copy link
Member

SunMarc commented Apr 9, 2025

@bot /style

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Style fixes have been applied. View the workflow run here.

@SunMarc
Copy link
Member

SunMarc commented Apr 10, 2025

@bot /style

@SunMarc SunMarc merged commit 583b26d into main Apr 15, 2025
2 checks passed
@SunMarc SunMarc deleted the muellerzr-fp8-runner branch April 15, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants