Speedup model loading by 4-5x in Diffusers ⚡#3674
Merged
SunMarc merged 5 commits intohuggingface:mainfrom Jul 11, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
a-r-r-o-w
commented
Jul 10, 2025
|
|
||
|
|
||
| >>> @find_executable_batch_size(starting_batch_size=128) | ||
| ... def train(batch_size, model, optimizer): |
Contributor
Author
There was a problem hiding this comment.
Change is unrelated. Seems to come from ruff, and I'm not sure why. I'm using the ruff version from the setup.py
SunMarc
approved these changes
Jul 10, 2025
Member
SunMarc
left a comment
SunMarc
left a comment
There was a problem hiding this comment.
Thanks for this ! A minor suggestion
src/accelerate/utils/modeling.py
Outdated
Comment on lines
+225
to
+226
| non_blocking: bool = False, | ||
| _empty_cache: bool = True, |
Member
There was a problem hiding this comment.
can you update the docstring also ? Also, maybe empty_cache or clear_cache ?
Contributor
Author
There was a problem hiding this comment.
@SunMarc Thanks, updated! Could you take a look again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sister PR in diffusers: huggingface/diffusers#11904