Skip to content

Fix: tp size wouldn't read from env#3716

Merged
SunMarc merged 1 commit intomainfrom
fix-tp
Aug 6, 2025
Merged

Fix: tp size wouldn't read from env#3716
SunMarc merged 1 commit intomainfrom
fix-tp

Conversation

@S1ro1
Copy link
Contributor

@S1ro1 S1ro1 commented Aug 6, 2025

With change in #3700 where we default to None, passing 1 as tp_size would result in env vars not being read.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@winglian winglian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. thanks!

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! nice catch

@SunMarc SunMarc merged commit 898cad3 into main Aug 6, 2025
28 of 29 checks passed
@SunMarc SunMarc deleted the fix-tp branch August 6, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants