fix: CPU RAM efficient loading for nd or HSDP parallelisms#3740
Merged
S1ro1 merged 1 commit intohuggingface:mainfrom Aug 21, 2025
Merged
fix: CPU RAM efficient loading for nd or HSDP parallelisms#3740S1ro1 merged 1 commit intohuggingface:mainfrom
S1ro1 merged 1 commit intohuggingface:mainfrom
Conversation
Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com>
Contributor
Author
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
@S1ro1 Thank you, can we merge this? |
Contributor
|
Yep, sorry forgot to come back to this after checks passed haha! |
Contributor
Author
Member
Contributor
Author
|
Thank you @SunMarc |
This was referenced Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes cpu ram efficient loading bug for nd parallel or even HSDP (replicate + shard) which needs broadcasting the tensor to all world ranks from global rank 0. Since from_pretrained from transformers is designed to load on global rank 0 in ram efficient loading case.
Fixes
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@S1ro1 @SunMarc @zach-huggingface