fix FSDP2 test case failure on XPU#3771
Merged
S1ro1 merged 2 commits intohuggingface:mainfrom Sep 12, 2025
Merged
Conversation
Signed-off-by: YAO Matrix <matrix.yao@intel.com>
Contributor
Author
|
@SunMarc , pls help review, thx |
yao-matrix
commented
Sep 10, 2025
| if self.device.type not in supported_device or is_torch_xla_available(check_is_tpu=True): | ||
| raise ValueError( | ||
| f"fp16 mixed precision requires a device in {supported_device} (not {self.device.type!r})." | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
prior error message is misleading.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug
when run
pytest -rA tests/fsdp/test_fsdp.py::FSDP2IntegrationTest::test_checkpointingon XPU, fail message asroot cause
when instantiate
GradScaleringet_fsdp2_grad_scaler, thedeviceis not passed, and will not becausedeviceis not inGradScalerKwargseither. In this case, PyTorch will defaultly set device tocuda, and lead to this issue.fix
explicitly pass
devicein.result
pass