Fix FSDP2 tied embedding errors with targeted ValueError guidance#3878
Merged
SunMarc merged 2 commits intohuggingface:mainfrom Dec 11, 2025
Merged
Fix FSDP2 tied embedding errors with targeted ValueError guidance#3878SunMarc merged 2 commits intohuggingface:mainfrom
SunMarc merged 2 commits intohuggingface:mainfrom
Conversation
SunMarc
approved these changes
Dec 9, 2025
Member
SunMarc
left a comment
SunMarc
left a comment
There was a problem hiding this comment.
Thanks ! Can you add a test for that ?
Contributor
Author
|
Thanks! Added the test |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces the raw KeyError in _prepare_fsdp2 param mapping with a defensive loop that collects all missing parameters and raises a targeted ValueError with actionable guidance for common tied embeddings mismatches (e.g., config has tie_word_embeddings=True but checkpoint has separate weights like in Qwen models).
Fixes #3870
Who can review?
@SunMarc
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.