Skip to content

Update rag_evaluation.ipynb #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Update rag_evaluation.ipynb #309

merged 1 commit into from
Jul 7, 2025

Conversation

hozRifai
Copy link
Contributor

@hozRifai hozRifai commented Jul 5, 2025

What does this PR do?

This PR corrects a small error in the text describing the evaluation metric. The original text mentioned faithfulness, but the code and the context of the evaluation are focused on Answer Correctness as the primary end-to-end metric in the article.
This change ensures the explanation accurately reflects the implementation.

Before:
Out of the different RAG evaluation metrics, we choose to focus only on faithfulness since it the best end-to-end metric of our system's performance
After:
Out of the different RAG evaluation metrics, we choose to focus only on Answer Correctness since it is the best end-to-end metric of our system's performance

Who can review?

@merveenoyan @stevhliu

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit 3ddbc42 into huggingface:main Jul 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants