Fix torchcodec audio decoding to respect 'num_channels'#8028
Open
AsymptotaX wants to merge 3 commits intohuggingface:mainfrom
Open
Fix torchcodec audio decoding to respect 'num_channels'#8028AsymptotaX wants to merge 3 commits intohuggingface:mainfrom
AsymptotaX wants to merge 3 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
lhoestq
reviewed
Feb 27, 2026
Member
lhoestq
left a comment
There was a problem hiding this comment.
Hi ! I believe ["array"] is used a lot in transformers and has been expecting mono for a long time - from before we switched to torchcodec. So we might need to keep mono as default for ["array"] unless num_channels is specified explicitly. Would it be ok for you ?
I see in your tests that you expect stereo even if num_channels is not specified in Audio()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes torchcodec audio decoding when
num_channelsis set onAudio.Before this change,
AudioDecoder["array"]reduced multi-channel audio to mono by averaging channels, so the requested channel behavior was not respected.With this PR:
num_channels == 1is explicitly requested.Previous behavior
ds_stereo = ds.cast_column("audio", Audio(num_channels={...}))- None, 1, 2Original file: '(16000, 2)' - stereo ✓
'Audio(num_channels=None)': '(16000,)' - mono ✗
'Audio(num_channels=2)': '(16000,)' - mono ✗
'Audio(num_channels=1)': '(16000,)' - mono ✓
New behavior
'num_channels=None' preserves the original number of channels from the source file.
'num_channels=2' preserves/converts to stereo output with shape '(2, num_samples)'.
'num_channels=1' downmixes to mono with shape '(num_samples,)'.
Results
Original file shape (via soundfile): (16000, 2)
HF datasets shape with num_channels=None: (2, 16000)
HF datasets shape with num_channels=1: (16000,)
HF datasets shape with num_channels=2: (2, 16000)
Fixes #8005.