Fix formatted iter arrow double yield#8063
Open
HaukurPall wants to merge 2 commits intohuggingface:mainfrom
Open
Fix formatted iter arrow double yield#8063HaukurPall wants to merge 2 commits intohuggingface:mainfrom
HaukurPall wants to merge 2 commits intohuggingface:mainfrom
Conversation
When features is falsy, yield from completes and then falls through to the for loop, iterating the inner iterable a second time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I (+Claude) noticed this when reading the code. I did not encounter this bug (I think) so I can't say much more about it. Perhaps the second iteration will immediately stop so the bug is harmless, but to be safe I think a return there is safer.